Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky data collection. Closes #249 #255

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Conversation

edavalosanaya
Copy link
Collaborator

@edavalosanaya edavalosanaya commented Sep 14, 2023

This PR does the following:

  • Refactors the file transfer implementation for both client and server
  • Added essential aioshutil and async-atexit packages to improve file handling and shutting down in async event loop
  • Makes the collect route of the Worker non-blocking. Now the Worker must inform the Manager once it has completed sending its archive to the Manager.
  • Added new route in the Manager to support Worker collection completion confirmation
  • Minor Bug fixes

TODO:

  • Implementation
  • Test with 2 computers
  • Test with windows

Fixes #249

…w the worker sends a collection completion confirmation via a new Manager route. Also restructured the Manager routine to be more fault-tolerant to single worker failure.
@edavalosanaya edavalosanaya self-assigned this Sep 14, 2023
@edavalosanaya edavalosanaya merged commit c84b582 into main Sep 15, 2023
3 checks passed
@edavalosanaya edavalosanaya deleted the 249-flaky-data-collection branch September 15, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty Flaky Data Collection
1 participant